stoty commented on code in PR #6616:
URL: https://github.com/apache/hbase/pull/6616#discussion_r1925472943
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/backup/HFileArchiver.java:
##########
@@ -421,50 +427,94 @@ public static void archiveStoreFile(Configuration conf,
FileSystem fs, RegionInf
*/
private static List<File> resolveAndArchive(FileSystem fs, Path
baseArchiveDir,
Collection<File> toArchive, long start) throws IOException {
- // short circuit if no files to move
+ // Early exit if no files to archive
if (toArchive.isEmpty()) {
+ LOG.trace("No files to archive, returning an empty list.");
return Collections.emptyList();
}
- LOG.trace("Moving files to the archive directory {}", baseArchiveDir);
+ LOG.trace("Preparing to archive files into directory: {}", baseArchiveDir);
Review Comment:
Come to think about it, your original comment is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
