jbewing opened a new pull request, #6642:
URL: https://github.com/apache/hbase/pull/6642

   ### What
   This PR updates block cache loads to not calculate 
`BlockCacheKey.toString()`—which has been observed causing higher allocation 
pressure than expected on busy region servers—if tracing isn't enabled. 
   
   ### How
   I used the Span.isRecordingEnabled API ([OpenTelemetry 
Docs](https://opentelemetry.io/docs/specs/otel/trace/api/#isrecording)). Based 
on the following docsnippet, I believe that this will work if OpenTelemetry 
isn't enabled for HBase:
   > This flag SHOULD be used to avoid expensive computations of a Span 
attributes or events in case when a Span is definitely not recorded. Note that 
any child span’s recording is determined independently from the value of this 
flag (typically based on the sampled flag of a TraceFlags on 
[SpanContext](https://opentelemetry.io/docs/specs/otel/trace/api/#spancontext)).
   
   
   [HBASE-29099](https://issues.apache.org/jira/browse/HBASE-29099)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to