junegunn commented on code in PR #5766:
URL: https://github.com/apache/hbase/pull/5766#discussion_r1936674832
##########
bin/hbase:
##########
@@ -221,6 +221,14 @@ if [ "$HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP" != "true" ]
; then
HADOOP_IN_PATH=$(PATH="${HADOOP_HOME:-${HADOOP_PREFIX}}/bin:$PATH" which
hadoop 2>/dev/null)
fi
+#If Hadoop is not specified with HADOOP_HOME, check that the assembly includes
Hadoop
+if [[ -z "${HADOOP_IN_PATH}" && ! -e "lib/hadoop-common*" ]] ; then
Review Comment:
@stoty I just noticed that I'm unable to start hbase in the local dev
environment (after `mvn install`) because of this. How about adding this
condition?
```diff
diff --git a/bin/hbase b/bin/hbase
index 8f58bf578a..5f1b845110 100755
--- a/bin/hbase
+++ b/bin/hbase
@@ -222,7 +222,7 @@ if [ "$HBASE_DISABLE_HADOOP_CLASSPATH_LOOKUP" != "true"
] ; then
fi
#If Hadoop is not specified with HADOOP_HOME, check that the assembly
includes Hadoop
-if [[ -z "${HADOOP_IN_PATH}" && ! -e "lib/hadoop-common*" ]] ; then
+if [[ $in_dev_env = false && -z "${HADOOP_IN_PATH}" && ! -e
"lib/hadoop-common*" ]] ; then
echo Installation does not contain Hadoop, and HADOOP_HOME does not point
to a Hadoop installation.
echo Specify a compatible Hadoop installation via HADOOP_HOME, or use the
HBase assembly variant
echo that includes Hadoop.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
