stoty commented on code in PR #6601:
URL: https://github.com/apache/hbase/pull/6601#discussion_r1938807109
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/SimpleServerRpcConnection.java:
##########
@@ -252,13 +253,14 @@ private void saslReadAndProcess(ByteBuff saslToken)
throws IOException, Interrup
doRawSaslReply(SaslStatus.SUCCESS, new BytesWritable(replyToken),
null, null);
}
if (saslServer.isComplete()) {
- String qop = saslServer.getNegotiatedQop();
- useWrap = qop != null && !"auth".equalsIgnoreCase(qop);
+ String negotiatedQop = saslServer.getNegotiatedQop();
Review Comment:
That's a good point.
finishSaslNegotiation does the same thing, but takes care of logging and
metrics, it's better to call that from here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
