junegunn commented on code in PR #6659:
URL: https://github.com/apache/hbase/pull/6659#discussion_r1940561381
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/client/CloneSnapshotFromClientAfterSplittingRegionTestBase.java:
##########
@@ -18,23 +18,29 @@
package org.apache.hadoop.hbase.client;
import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
import java.io.IOException;
import java.util.List;
+import org.apache.hadoop.hbase.MetaTableAccessor;
import org.apache.hadoop.hbase.TableName;
import org.apache.hadoop.hbase.master.RegionState;
import org.apache.hadoop.hbase.master.assignment.RegionStates;
import org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils;
-import org.apache.hadoop.hbase.util.Bytes;
import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.junit.Test;
public class CloneSnapshotFromClientAfterSplittingRegionTestBase
extends CloneSnapshotFromClientTestBase {
- private void splitRegion(final RegionInfo regionInfo) throws IOException {
- byte[][] splitPoints = Bytes.split(regionInfo.getStartKey(),
regionInfo.getEndKey(), 1);
- admin.split(regionInfo.getTable(), splitPoints[1]);
Review Comment:
Previously, this would split the first region whose start key is an empty
bytes and end key is `[49] "1"`. The resulting split point is `[24]` and
because there is no data before `[48] "0"`, this would not generate any
reference files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
