DieterDP-ng commented on PR #6506: URL: https://github.com/apache/hbase/pull/6506#issuecomment-2643025503
Fixed the checkstyle error. @ndimiduk @rmdmattingly the discussion on Jira about the best approach stopped. Should I wait for further feedback? Personally, I think the best solution would be to track in the backup system table whether a full backup is required or not. This tracking would have to occur through an Observer as is done in this ticket. Given that this PR solves a real issue, I'd suggest to include it, and leave the switch to the tracking system to a later commit. Note that users should update their config to include the new observer. Not sure if this counts as a migration since the backup is still considered experimental. Should be mentioned somewhere though, but unsure where. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
