rmdmattingly commented on code in PR #6651:
URL: https://github.com/apache/hbase/pull/6651#discussion_r1946575138
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerClusterState.java:
##########
@@ -711,6 +726,44 @@ enum LocalityType {
RACK
}
+ public List<RegionPlan> convertActionToPlans(BalanceAction action) {
Review Comment:
Doing this work actually revealed a bug for me — we weren't properly
implementing BalanceAction#undoAction for the MoveBatchAction. This was hidden
because batches are currently only proposed by conditionals, and conditional
suggestions are always accepted so a bugged "undone" process wouldn't surface.
I've fixed this locally, and am also updating `BalanceAction#undoAction` to be
abstract so that we force an impl in a less error prone way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
