[
https://issues.apache.org/jira/browse/HBASE-29116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ZhongYou Li updated HBASE-29116:
--------------------------------
Description:
when the server crash down, old source will be closed, recovered source will
start.when replicate completed,we should terminate the source and remove from
oldsources ,is that？
{code:java}
/**
* Clear the metrics and related replication queue of the specified old source
* @param src source to clear
*/
private boolean removeRecoveredSource(ReplicationSourceInterface src) {
if (!this.oldsources.remove(src)) {
return false;
}
LOG.info("Done with the recovered queue {}", src.getQueueId());
// Delete queue from storage and memory
deleteQueue(src.getQueueId());
this.walsByIdRecoveredQueues.remove(src.getQueueId());
return true;
} {code}
was:
when the server crash down, old source will be closed, recovered source will
start.when replicate completed,we should terminate the source and remove from
oldsources ,is that？
{code:java}
/**
* Clear the metrics and related replication queue of the specified old source
* @param src source to clear
*/
private boolean removeRecoveredSource(ReplicationSourceInterface src) {
if (!this.oldsources.remove(src)) {
return false;
}
LOG.info("Done with the recovered queue {}", src.getQueueId());
// Delete queue from storage and memory
deleteQueue(src.getQueueId());
this.walsByIdRecoveredQueues.remove(src.getQueueId());
return true;
} {code}
> recoveredSource can not close thread
> ------------------------------------
>
> Key: HBASE-29116
> URL: https://issues.apache.org/jira/browse/HBASE-29116
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.4.18
> Reporter: selina.yan
> Priority: Minor
>
> when the server crash down, old source will be closed, recovered source will
> start.when replicate completed,we should terminate the source and remove from
> oldsources ,is that？
> {code:java}
> /**
> * Clear the metrics and related replication queue of the specified old
> source
> * @param src source to clear
> */
> private boolean removeRecoveredSource(ReplicationSourceInterface src) {
> if (!this.oldsources.remove(src)) {
> return false;
> }
> LOG.info("Done with the recovered queue {}", src.getQueueId());
> // Delete queue from storage and memory
> deleteQueue(src.getQueueId());
> this.walsByIdRecoveredQueues.remove(src.getQueueId());
> return true;
> } {code}
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
