rmdmattingly commented on code in PR #6651:
URL: https://github.com/apache/hbase/pull/6651#discussion_r1966147275
##########
hbase-balancer/src/test/java/org/apache/hadoop/hbase/master/balancer/TestLargeClusterBalancingConditionalReplicaDistribution.java:
##########
@@ -96,11 +96,10 @@ private static TableName getTableName(int i) {
@Test
public void testReplicaDistribution() {
Configuration conf = new Configuration(true);
- conf.setBoolean(BalancerConditionals.DISTRIBUTE_REPLICAS_KEY, true);
- conf.setBoolean(DistributeReplicasConditional.TEST_MODE_ENABLED_KEY, true);
+
DistributeReplicasTestConditional.enableConditionalReplicaDistributionForTest(conf);
conf.setBoolean(ReplicaKeyCache.CACHE_REPLICA_KEYS_KEY, true);
conf.setInt(ReplicaKeyCache.REPLICA_KEY_CACHE_SIZE_KEY, Integer.MAX_VALUE);
- conf.setLong("hbase.master.balancer.stochastic.maxRunningTime", 30_000);
+ conf.setLong("hbase.master.balancer.stochastic.maxRunningTime", 120_000);
Review Comment:
Because the balancer will iterate, it doesn't really matter what this is set
to (as long it's not far too short or indefinitely long I suppose). So I'm
going to change this back, I was just playin' around and committed this by
accident
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
