stoty commented on PR #6010: URL: https://github.com/apache/hbase/pull/6010#issuecomment-2677542999
Can we get back to this patch, @Apache9 ? To recap: This is a perf optimization for the included REST Client, that avoids copying the full HTTP response into a byte array before feeding it into protobuf, in favor of using streams, which saves both memory and CPU. ProtobufHttpEntity is a similar optimization for uploading large mutations, which again avoids storing the protobuf output to a byte array before uploading, and instead allows streaming the protobuf marshaller output directly to HTTP. I have also updated the code to use ClosableHttpResponse instead of HttpResponse. None of this affects the server code. While this does expose some Apache HttpClient classes in the API, this is nothing new, as the current Client already does the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
