wchevreuil commented on code in PR #6763:
URL: https://github.com/apache/hbase/pull/6763#discussion_r1988100606
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/CacheAwareLoadBalancer.java:
##########
@@ -53,6 +55,12 @@
public class CacheAwareLoadBalancer extends StochasticLoadBalancer {
private static final Logger LOG =
LoggerFactory.getLogger(CacheAwareLoadBalancer.class);
+ public static final String CACHE_RATIO_THRESHOLD =
"hbase.master.balancer.stochastic.cacheRatio";
+
+ public static final String MOVE_THROTTLING =
"hbase.master.balancer.move.throttlingMs";
Review Comment:
Good point. Right now, it's only implemented by the cache aware balancer.
But since it may be implemented by other possible balancer implementations in
the future, I thought may be worth move these two to the LoadBalancer interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
