[ 
https://issues.apache.org/jira/browse/HBASE-28987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17934089#comment-17934089
 ] 

Duo Zhang commented on HBASE-28987:
-----------------------------------

The patch you provided added thousand lines of code, and introduce more 
concepts like ReplicationResult, this obviously increases the complexity...

Looking at the patch, I do not think this is the correct way to address the 
problem

{code}
  default void logPositionAndCleanOldLogs(WALEntryBatch entryBatch, 
ReplicationResult replicated) {

  }
{code}

If the ReplicationResult is not COMMITTED, we should not call the 
logPositionAndCleanOldLogs right?That's why I said above that the persist 
interval should be controlled by the upper layer...

For me I always believe that, we should try our best to not introduce more 
concepts...

Thanks.

> Developing a Custom ReplicationEndpoint to Support External Storage 
> Integration
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-28987
>                 URL: https://issues.apache.org/jira/browse/HBASE-28987
>             Project: HBase
>          Issue Type: Task
>          Components: backup&restore
>    Affects Versions: 2.6.0, 3.0.0-alpha-4
>            Reporter: Vinayak Hegde
>            Assignee: Vinayak Hegde
>            Priority: Major
>
> *Develop a Custom Replication Endpoint*
> Implement a custom replication endpoint to support the backup of WALs to 
> external storage systems, such as HDFS-compliant storages (including HDFS, 
> S3, ADLS, and GCS via respective Hadoop connectors).
> *Support for Bulk-loaded Files*
> Add functionality to back up bulk-loaded files in addition to regular WALs.
> *Ensure Process Durability*
> Ensure the backup process is durable, with no WALs being missed, even in the 
> event of issues in the cluster.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to