[
https://issues.apache.org/jira/browse/HBASE-6550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434706#comment-13434706
]
Jean-Daniel Cryans commented on HBASE-6550:
-------------------------------------------
The TPE looks ok.
Shouldn't the conf be cloned? I'm worried about propagating those client-side
configurations back in the RS. You never know when this can bite us especially
in unit tests.
Don't do this:
{code}
LOG.warn("interrupted while terminating: " + e);
{code}
They put a second argument on those calls just for the exceptions. Also try
having error messages that are more descriptive about the context.
On the nitpick-side of things:
- Call {{exec}} something more specific to what it is
- Call {{con}} something more specific to what it is
- "Its called" should be "It's called"
> Refactoring ReplicationSink to make it more responsive of cluster health
> ------------------------------------------------------------------------
>
> Key: HBASE-6550
> URL: https://issues.apache.org/jira/browse/HBASE-6550
> Project: HBase
> Issue Type: New Feature
> Components: replication
> Reporter: Himanshu Vashishtha
> Assignee: Himanshu Vashishtha
> Attachments: 6550-havealook.txt, HBase-6550.patch,
> HBase-6550-v1.patch, HBase-6550-v3.patch
>
>
> ReplicationSink replicates the WALEdits in the local cluster. It uses native
> HBase client to insert the mutations. Sometime, it takes a while to process
> it (may be due to region splitting, gc pause, etc) and it undergoes the
> retrial phase.
> It has two repercussions:
> a) The regionserver handler which is serving the request (till now, a
> priority handler) is blocked for this period.
> b) The caller may get timed out and it will retry it anyway, but the handler
> serving the ReplicationSink requests is still working.
> Refactoring ReplicationSink to have the following features:
> a) Making it more configurable (have its own number of retrial limit,
> connection timeout, etc)
> b) Add a fail fast behavior so that it bails out in case caller is timedout,
> or any exception in processing the mutation batch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
