[ https://issues.apache.org/jira/browse/HBASE-6569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434718#comment-13434718 ]
Hadoop QA commented on HBASE-6569: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12540950/6569-v3.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 27 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2571//console This message is automatically generated. > Extract HStore interface from Store > ----------------------------------- > > Key: HBASE-6569 > URL: https://issues.apache.org/jira/browse/HBASE-6569 > Project: HBase > Issue Type: Sub-task > Affects Versions: 0.96.0 > Reporter: Jesse Yates > Assignee: Jesse Yates > Fix For: 0.96.0 > > Attachments: 6569-v3.patch, java_HBASE-6569-v0.patch > > > Currently Store.java is a top-level class. However, we need to to use the > same interface for snapshots (HBASE-6055), and potentially other uses-cases > as well, but subclassing is 'dirty' given the amount of state that a Store > currently builds up on instantiation. > For snapshots, we just need to modify the Store actions slightly, making a > composition with interface inheritance design very appealing (meaning we need > an interface for Store). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira