ndimiduk commented on code in PR #6821:
URL: https://github.com/apache/hbase/pull/6821#discussion_r2003304664
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BalancerConditionals.java:
##########
@@ -145,7 +145,7 @@ int getViolationCountChange(BalancerClusterState cluster,
BalanceAction action)
// Reset cluster
cluster.doAction(undoAction);
- if (isViolatingPre && isViolatingPost) {
+ if (isViolatingPre == isViolatingPost) {
return 0;
Review Comment:
Since this was so impactful to behavior, maybe good to capture this method
in a unit test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
