[ 
https://issues.apache.org/jira/browse/HBASE-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434804#comment-13434804
 ] 

Zhihong Ted Yu commented on HBASE-6340:
---------------------------------------

When I put this patch on top of latest patch from HBASE-6414, I got:
{code}
testCalls(org.apache.hadoop.hbase.ipc.TestProtocolExtension)  Time elapsed: 
0.767 sec  <<< ERROR!
java.lang.NullPointerException
  at 
org.apache.hadoop.hbase.ipc.ProtobufRpcEngine$Invoker.constructRpcRequest(ProtobufRpcEngine.java:130)
  at 
org.apache.hadoop.hbase.ipc.ProtobufRpcEngine$Invoker.invoke(ProtobufRpcEngine.java:175)
  at $Proxy5.ping(Unknown Source)
  at 
org.apache.hadoop.hbase.ipc.TestProtocolExtension.testCalls(TestProtocolExtension.java:91)
{code}
which is this line in constructRpcRequest():
{code}
      int length = params.length;
{code}

You can rebase patch on 0.94 so that Lars can take a look.

For trunk, investigation is needed after HBASE-6414 goes in.
                
> HBase RPC does not allow protocol extension with common interfaces.
> -------------------------------------------------------------------
>
>                 Key: HBASE-6340
>                 URL: https://issues.apache.org/jira/browse/HBASE-6340
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors, regionserver
>    Affects Versions: 0.92.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: RPCInvocation.patch
>
>
> HBase RPC fails if MyProtocol extends an interface, which is not a 
> VersionedProtocol even if MyProtocol also directly extends VersionedProtocol. 
> The reason is that rpc Invocation uses Method.getDeclaringClass(), which 
> returns the interface class rather than the class of MyProtocol.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to