NihalJain commented on PR #131: URL: https://github.com/apache/hbase-thirdparty/pull/131#issuecomment-2760389706
The eeX tends to transitively bring in few dependencies. Hence, breaking into core we might have duplicates of same into 2 jars. So we may have remove the transitive dependencies which are in the core from eeX or merge core + eeX as a single fat jar. By just breaking into 3 modules with core, ee8 and ee9 specific dependencies in pom, result into as below. ``` [INFO] ----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core >----- [INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core 4.1.11-SNAPSHOT [8/13] [INFO] from hbase-shaded-jetty-12-plus-core/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-core --- [INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-core:jar:4.1.11-SNAPSHOT [INFO] +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile [INFO] +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile [INFO] +- org.eclipse.jetty:jetty-util:jar:12.0.18:compile [INFO] +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile [INFO] +- org.eclipse.jetty:jetty-jmx:jar:12.0.18:compile [INFO] \- org.eclipse.jetty:jetty-util-ajax:jar:12.0.18:compile [INFO] [INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8 >----- [INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 4.1.11-SNAPSHOT [9/13] [INFO] from hbase-shaded-jetty-12-plus-ee8/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee8 --- [INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee8:jar:4.1.11-SNAPSHOT [INFO] +- org.eclipse.jetty.ee8:jetty-ee8-servlet:jar:12.0.18:compile [INFO] +- org.eclipse.jetty.ee8:jetty-ee8-security:jar:12.0.18:compile [INFO] +- org.eclipse.jetty.ee8:jetty-ee8-nested:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile [INFO] | | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile [INFO] | | \- org.eclipse.jetty:jetty-util:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-security:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile [INFO] | \- org.eclipse.jetty.toolchain:jetty-servlet-api:jar:4.0.6:compile [INFO] \- org.eclipse.jetty.ee8:jetty-ee8-webapp:jar:12.0.18:compile [INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile [INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile [INFO] [INFO] -----< org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9 >----- [INFO] Building Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE9 4.1.11-SNAPSHOT [10/13] [INFO] from hbase-shaded-jetty-12-plus-ee9/pom.xml [INFO] --------------------------------[ jar ]--------------------------------- [INFO] [INFO] --- dependency:3.6.0:tree (default-cli) @ hbase-shaded-jetty-12-plus-ee9 --- [INFO] org.apache.hbase.thirdparty:hbase-shaded-jetty-12-plus-ee9:jar:4.1.11-SNAPSHOT [INFO] +- org.eclipse.jetty.ee9:jetty-ee9-servlet:jar:12.0.18:compile [INFO] +- org.eclipse.jetty.ee9:jetty-ee9-security:jar:12.0.18:compile [INFO] | \- org.eclipse.jetty:jetty-security:jar:12.0.18:compile [INFO] +- org.eclipse.jetty.ee9:jetty-ee9-nested:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-http:jar:12.0.18:compile [INFO] | | +- org.eclipse.jetty:jetty-io:jar:12.0.18:compile [INFO] | | \- org.eclipse.jetty:jetty-util:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-server:jar:12.0.18:compile [INFO] | +- org.eclipse.jetty:jetty-session:jar:12.0.18:compile [INFO] | \- org.eclipse.jetty.toolchain:jetty-jakarta-servlet-api:jar:5.0.2:compile [INFO] \- org.eclipse.jetty.ee9:jetty-ee9-webapp:jar:12.0.18:compile [INFO] +- org.eclipse.jetty:jetty-ee:jar:12.0.18:compile [INFO] \- org.eclipse.jetty:jetty-xml:jar:12.0.18:compile [INFO] `` Which approach do you suggest? - transitive removal in eeX which exist in core - or core + eeX as a single fat for each X -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
