NihalJain commented on code in PR #6783:
URL: https://github.com/apache/hbase/pull/6783#discussion_r2019159087
##########
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java:
##########
@@ -1213,14 +1212,14 @@ public void start() throws IOException {
} catch (IOException ex) {
LOG.info("HttpServer.start() threw a non Bind IOException", ex);
throw ex;
- } catch (MultiException ex) {
+ } catch (Exception ex) {
Review Comment:
Jetty throws either of these, maybe should handle Error as well here. Refer
https://github.com/jetty/jetty.project/blob/ccdbe1742eac511914869a53f0efc2075775d0b8/jetty-core/jetty-util/src/main/java/org/eclipse/jetty/util/ExceptionUtil.java#L81
```
/**
* Throw a {@link Throwable} as a checked {@link Exception} if it
* cannot be thrown as unchecked.
* @param throwable The {@link Throwable} to throw or null.
* @throws Error If the passed {@link Throwable} is an {@link Error}.
* @throws Exception Otherwise, if the passed {@link Throwable} is not
null.
*/
public static void ifExceptionThrow(Throwable throwable)
throws Error, Exception
{
if (throwable == null)
return;
if (throwable instanceof Error error)
throw error;
if (throwable instanceof Exception exception)
throw exception;
throw new RuntimeException(throwable);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
