taklwu commented on code in PR #6763:
URL: https://github.com/apache/hbase/pull/6763#discussion_r2008327863
##########
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/CacheAwareLoadBalancer.java:
##########
@@ -53,6 +55,13 @@
public class CacheAwareLoadBalancer extends StochasticLoadBalancer {
private static final Logger LOG =
LoggerFactory.getLogger(CacheAwareLoadBalancer.class);
+ public static final String CACHE_RATIO_THRESHOLD =
+ "hbase.master.balancer.stochastic.throttling.cacheRatio";
+ public static final float CACHE_RATIO_THRESHOLD_DEFAULT = 0.8f;
Review Comment:
[nit] do you think we need a doc update about this feature ?
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestBlockEvictionOnRegionMovement.java:
##########
@@ -82,6 +83,7 @@ public void setup() throws Exception {
conf.set("hbase.bucketcache.persistent.path", testDir +
"/bucket.persistence");
conf.setLong(CacheConfig.BUCKETCACHE_PERSIST_INTERVAL_KEY, 100);
conf.setBoolean(CacheConfig.EVICT_BLOCKS_ON_CLOSE_KEY, true);
+ conf.setBoolean(CACHE_BLOCKS_ON_WRITE_KEY, true);
Review Comment:
[nit] why do we need to add the cache blocks on write here? does anyone
change the test behavior? I cannot find any other edits in this file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
