ndimiduk commented on code in PR #6864:
URL: https://github.com/apache/hbase/pull/6864#discussion_r2021634617
##########
hbase-rest/pom.xml:
##########
@@ -295,7 +295,7 @@
<overwrite>true</overwrite>
<resources>
<resource>
-
<directory>../hbase-server/src/main/resources/hbase-webapps/static</directory>
+
<directory>../hbase-server/target/hbase-webapps/static</directory>
Review Comment:
I know that this is how you found it, but does it make better sense to
include an explicit dependency on the new webjars jar from hbase-rest? I doubt
that we can remove the dependency on hbase-server, but it would be one fewer
thing and make the dependency tree more obvious.
##########
hbase-server/pom.xml:
##########
@@ -524,6 +524,44 @@
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
<executions>
+ <execution>
+ <!-- Copy static CSS and JS files for the UI. -->
+ <id>copy-css-js-to-ui</id>
+ <goals>
+ <goal>run</goal>
+ </goals>
+ <phase>process-resources</phase>
+ <configuration>
+ <target>
+ <copy flatten="true"
todir="${project.build.directory}/hbase-webapps/static/css">
Review Comment:
Is it okay to flatten these files? I doubt that we want to perform any
processing on their content...
##########
hbase-server/pom.xml:
##########
@@ -524,6 +524,44 @@
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
<executions>
+ <execution>
+ <!-- Copy static CSS and JS files for the UI. -->
+ <id>copy-css-js-to-ui</id>
+ <goals>
+ <goal>run</goal>
Review Comment:
Is it possible to remove this copy stage and instead place the resources as
part of the unpack action below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
