PDavid opened a new pull request, #6875:
URL: https://github.com/apache/hbase/pull/6875

   This is the first step of the Jamon to JSP migration is the Master Status 
page.
   
   Moved the Jamon code back to JSP. Changed the Jamon syntax back to JSP.
   To transfer data between JSP pages I used request attributes.
   Tried to preserve the code as much as possible but did some changes:
   
   Sub-templates were usually extracted to separate JSP file, in some case it 
is extracted as Java method.
   
   Extracted some sections from master page to separate JSP pages:
   - Software Attributes
   - Warnings
   
   Extracted some frequently used static methods to a new util class: 
`MasterStatusUtil`. Also added unit tests for the static methods in 
`MasterStatusUtil`. 
   
   Changed the Master Status page back to `/master.jsp` again. Now deleted the 
servlet at `/master-status` but if you see it required, we can have a redirect 
from `/master-status` to `/master.jsp`.
   
   What do you think about this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to