[
https://issues.apache.org/jira/browse/HBASE-6471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435462#comment-13435462
]
Hadoop QA commented on HBASE-6471:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541094/trunk-6471_v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than
the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/2592//console
This message is automatically generated.
> Performance regression caused by HBASE-4054
> -------------------------------------------
>
> Key: HBASE-6471
> URL: https://issues.apache.org/jira/browse/HBASE-6471
> Project: HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.92.0
> Reporter: Lars George
> Assignee: Jimmy Xiang
> Priority: Critical
> Fix For: 0.96.0, 0.94.2
>
> Attachments: trunk-6471.patch, trunk-6471.patch, trunk-6471_v2.patch
>
>
> The patch in HBASE-4054 switches the PooledHTable to extend HTable as opposed
> to implement HTableInterface.
> Since HTable does not have an empty constructor, the patch added a call to
> the super() constructor, which though does trigger the ZooKeeper and META
> scan, causing a considerable delay.
> With multiple threads using the pool in parallel, the first thread is holding
> up all the subsequent ones, in effect it negates the whole reason we have a
> HTable pool.
> We should complete HBASE-5728, or alternatively add a protected, empty
> constructor the HTable. I am +1 for the former.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira