NihalJain commented on code in PR #6893:
URL: https://github.com/apache/hbase/pull/6893#discussion_r2035740421
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -230,11 +235,16 @@ private static void checkCompactionPolicy(final
Configuration conf, final TableD
}
for (ColumnFamilyDescriptor hcd : td.getColumnFamilies()) {
+ Configuration cfConf =
+ new
CompoundConfiguration().add(conf).addStringMap(hcd.getConfiguration());
String compactionPolicy =
-
hcd.getConfigurationValue(DefaultStoreEngine.DEFAULT_COMPACTION_POLICY_CLASS_KEY);
- if (compactionPolicy == null) {
- compactionPolicy = className;
+ cfConf.get(DefaultStoreEngine.DEFAULT_COMPACTION_POLICY_CLASS_KEY,
className);
Review Comment:
this wont handle the cnfe right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
