mwkang commented on code in PR #6900:
URL: https://github.com/apache/hbase/pull/6900#discussion_r2039668086


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:
##########
@@ -640,6 +648,11 @@ public boolean next(List<? super ExtendedCell> outResult, 
ScannerContext scanner
         scannerContext.setLastPeekedCell(cell);
         topChanged = false;
         ScanQueryMatcher.MatchCode qcode = matcher.match(cell);
+
+        if (hook != null) {

Review Comment:
   I didn't want to introduce a hook class, but I needed to trigger a flush at 
a specific point within the 
[LOOP](https://github.com/apache/hbase/blob/0b3c17302843d1f4d6f3c6b458f837cb9c274510/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java#L597).
   In HBASE-18295, the test used a 
[MyList](https://github.com/apache/hbase/blob/0b3c17302843d1f4d6f3c6b458f837cb9c274510/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHStore.java#L3015)
 class to achieve this, and I wanted to use a similar approach, but I couldn’t 
find a way to do it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to