Yiran-wu commented on code in PR #6856:
URL: https://github.com/apache/hbase/pull/6856#discussion_r2046065915
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/RecoveredReplicationSource.java:
##########
@@ -104,7 +106,30 @@ public void locateRecoveredPaths(String walGroupId) throws
IOException {
// didn't find a new location
LOG.error(
String.format("WAL Path %s doesn't exist and couldn't find its new
location", path));
- newPaths.add(path);
+ Path walPath = path;
+ if (
Review Comment:
After we create RecoveredReplicationSource, we will add a list of WAL files,
and the Path under the oldWALs directory.
```
// ReplicationSourceManager.java:700
oldsources.add(src);
LOG.info("Added source for recovered queue {}", src.getQueueId());
for (String wal : walsSet) {
LOG.trace("Enqueueing log from recovered queue for source: " +
src.getQueueId());
src.enqueueLog(new Path(oldLogDir, wal));
}
src.startup();
```
I tried to change it to the actual path, but if the queue has been failover
2 or more, it will require a lot of judgments and parse.
The current version of the code tries to put the original generated path。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
