taklwu commented on code in PR #6897:
URL: https://github.com/apache/hbase/pull/6897#discussion_r2059067662
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -911,6 +900,22 @@ boolean evictBucketEntryIfNoRpcReferenced(BlockCacheKey
blockCacheKey, BucketEnt
return false;
}
+ @Override
+ public void onConfigurationChange(Configuration config) {
+ this.acceptableFactor = conf.getFloat(ACCEPT_FACTOR_CONFIG_NAME,
DEFAULT_ACCEPT_FACTOR);
Review Comment:
nit: can we add a comment of javadoc on what properties could not be dynamic
config? basically we changed `ConfigurationObserver` to be part of the dynamic
config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
