guluo2016 commented on code in PR #6947:
URL: https://github.com/apache/hbase/pull/6947#discussion_r2077724527


##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatImpl.java:
##########
@@ -145,13 +146,19 @@ public static class InputSplit implements Writable {
     private String[] locations;
     private String scan;
     private String restoreDir;
+    private long length;
 
     // constructor for mapreduce framework / Writable
     public InputSplit() {
     }
 
     public InputSplit(TableDescriptor htd, RegionInfo regionInfo, List<String> 
locations, Scan scan,
       Path restoreDir) {
+      this(htd, regionInfo, locations, scan, restoreDir, 1);

Review Comment:
   This doesn't seem quite right in here, because 
SnapShotStats.getStoreFilesSize() would return 0 if the table has no any data.
   What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to