Apache9 commented on code in PR #6982:
URL: https://github.com/apache/hbase/pull/6982#discussion_r2087002781
##########
bin/hbase-daemon.sh:
##########
@@ -376,6 +376,19 @@ case $startStop in
wait_until_done $!
;;
+(status)
+ if [ -f $HBASE_PID ]; then
+ pid=`cat $HBASE_PID`
+ if kill -0 "$pid" > /dev/null 2>&1; then
Review Comment:
IIRC, kill -0 also work for a tid, and also if the process is already dead
and another process reuses the pid, this may incorrectly report the state.
IIRC for master and regionserver, we will add a `-Dproc_master` or
`-Dproc_regionserver` in the start command, we could first check if the process
is what we expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
