NihalJain commented on code in PR #6993:
URL: https://github.com/apache/hbase/pull/6993#discussion_r2096127762
##########
hbase-shaded/pom.xml:
##########
@@ -90,7 +90,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.5.1</version>
+ <version>3.6.0</version>
Review Comment:
> No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11 That
combination handles anything up to Java 24.
>
> But if maven-shade-plugin 3.6.0 solves all problems by itself, then we
don't have to update byte-buddy now.
Ah got it! Let's make byte-buddy change later, if that is fine. As you
rightly pointed we currently getting 1.12.19 transitively via mockito, which
maybe causes issue with Java 24.
```
[INFO] +- org.mockito:mockito-core:jar:4.11.0:test
[INFO] | +- net.bytebuddy:byte-buddy:jar:1.12.19:test
[INFO] | +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
```
##########
hbase-shaded/pom.xml:
##########
@@ -90,7 +90,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.5.1</version>
+ <version>3.6.0</version>
Review Comment:
> No, I mean maven-shade-plugin 3.6.0 and byte-buddy 1.15.11 That
combination handles anything up to Java 24.
>
> But if maven-shade-plugin 3.6.0 solves all problems by itself, then we
don't have to update byte-buddy now.
Ah got it! Let's make byte-buddy change later, if that is fine? As you
rightly pointed we currently getting 1.12.19 transitively via mockito, which
maybe causes issue with Java 24.
```
[INFO] +- org.mockito:mockito-core:jar:4.11.0:test
[INFO] | +- net.bytebuddy:byte-buddy:jar:1.12.19:test
[INFO] | +- net.bytebuddy:byte-buddy-agent:jar:1.12.19:test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
