NihalJain commented on code in PR #7016: URL: https://github.com/apache/hbase/pull/7016#discussion_r2102337946
########## hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseSemanticAttributes.java: ########## @@ -18,25 +18,28 @@ package org.apache.hadoop.hbase.trace; import io.opentelemetry.api.common.AttributeKey; -import io.opentelemetry.semconv.SemanticAttributes; +import io.opentelemetry.semconv.ExceptionAttributes; +import io.opentelemetry.semconv.incubating.DbIncubatingAttributes; +import io.opentelemetry.semconv.incubating.RpcIncubatingAttributes; +import io.opentelemetry.semconv.incubating.NetIncubatingAttributes; import java.nio.ByteBuffer; import java.util.List; import org.apache.yetus.audience.InterfaceAudience; /** * The constants in this class correspond with the guidance outlined by the OpenTelemetry <a href= - * "https://github.com/open-telemetry/opentelemetry-specification/tree/main/specification/trace/semantic_conventions";>Semantic + * "https://github.com/open-telemetry/semantic-conventions/tree/main/docs#opentelemetry-semantic-conventions";>Semantic * Conventions</a>. */ @InterfaceAudience.Private public final class HBaseSemanticAttributes { - public static final AttributeKey<String> DB_SYSTEM = SemanticAttributes.DB_SYSTEM; - public static final String DB_SYSTEM_VALUE = SemanticAttributes.DbSystemValues.HBASE; + public static final AttributeKey<String> DB_SYSTEM = DbIncubatingAttributes.DB_SYSTEM; Review Comment: Most of these have been deprecated, we need to see whether we want to continue using these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
