[
https://issues.apache.org/jira/browse/HBASE-29283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17955784#comment-17955784
]
Hudson commented on HBASE-29283:
--------------------------------
Results for branch master
[build #1302 on
builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1302/]:
(x) *{color:red}-1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1302/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk17 hadoop3 checks{color}
-- For more information [see jdk17
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1302/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk17 hadoop 3.3.5 backward compatibility checks{color}
-- For more information [see jdk17
report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/master/1302/JDK17_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test for 3.3.5 {color}
(/) {color:green}+1 client integration test for 3.3.6 {color}
> Replication MetricsSource.sizeOfHFileRefsQueue metrics not updated correctly
> after remove_peer
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-29283
> URL: https://issues.apache.org/jira/browse/HBASE-29283
> Project: HBase
> Issue Type: Bug
> Reporter: Chandra Sekhar K
> Assignee: Chandra Sekhar K
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.7.0, 3.0.0-beta-2, 2.6.3, 2.5.12
>
>
> in Replication MetricsSource, the value of lastHFileRefsQueueSize not
> incremented correctly, due to this the corresponding decrement in
> decrSizeOfHFileRefsQueue functions resulting in wrong value.
>
> {code:java}
> public void incrSizeOfHFileRefsQueue(long size) {
> singleSourceSource.incrSizeOfHFileRefsQueue(size);
> globalSourceSource.incrSizeOfHFileRefsQueue(size);
> lastHFileRefsQueueSize = size; //issue here as the value not appended with
> previous value
> }
> public void decrSizeOfHFileRefsQueue(int size) {
> singleSourceSource.decrSizeOfHFileRefsQueue(size);
> globalSourceSource.decrSizeOfHFileRefsQueue(size);
> lastHFileRefsQueueSize -= size; // this results in wrong value
> if (lastHFileRefsQueueSize < 0) {
> lastHFileRefsQueueSize = 0;
> }
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
