kgeisz commented on PR #6887: URL: https://github.com/apache/hbase/pull/6887#issuecomment-2941732509
> > Should we have a unit test case for switching the active cluster? > > cc. @anmolnar > > Could you please elaborate on that? Tests in this patch cover the different startup scenarios for HBase and validates it behaves as expected. Switching the active cluster sounds to me a multi-step operation which is beyond the scope here, but correct me if I'm wrong. Yes, I was talking about more complex scenarios mentioned in the design doc. In this case, I was talking about verifying a failure occurs when the scenario in the [ticket description](https://issues.apache.org/jira/browse/HBASE-29228) happens. I'm also wondering if we should make unit tests that verify failures for these scenarios mentioned in the doc: 1. active cluster startup attempted after setting hbase.global.readonly.enabled to true 2. replica cluster startup attempted after setting hbase.global.readonly.enabled to false I agree with you though. This patch is a small change that prevents multiple running clusters, and the unit tests verify that behavior is correct, so the tests I'm thinking of are beyond the scope of this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
