hgromer commented on PR #7084:
URL: https://github.com/apache/hbase/pull/7084#issuecomment-2959924484
> > Enabling/disabling tables happens often enough that it might be fine to
simply fail and force the user to manually handle the failure.
>
> Do you mean "happens ~often~ infrequently enough"? If so, I agree that
snapshotting a disabled table should be a pretty exceptional request, and so it
is fine to err on the side of simplicity and just fail the procedure
Yes I did; I am happy to fail the procedure if that's the general consensus.
That being said, I do think modern backups start to stress this system out. Any
call to the BackupAdmin triggers an enable table procedure, so we're more
likely to get into this state.
If we are okay with failing, then the user will have to manually kick off
another snapshot on failure.
Another possible solution would be to reset the state of the snapshot
procedure, so that it needs to run from the beginning
```java
if (tableState.isEnabled()) {
// action
} else if (tableState.isDisabled) {
// action
} else {
// set up suspension timeout/persistence
setNextState(SnapshotState.SNAPSHOT_PREPARE);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
