droudnitsky commented on code in PR #7079:
URL: https://github.com/apache/hbase/pull/7079#discussion_r2147021107
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -448,30 +448,22 @@ void groupAndSendMultiAction(List<Action> currentActions,
int numAttempt) {
boolean isReplica = false;
List<Action> unknownReplicaActions = null;
+ List<Action> locateRegionFailedActions = null;
for (Action action : currentActions) {
if (isOperationTimeoutExceeded()) {
- String message = numAttempt == 1
Review Comment:
The logic here has been preserved exactly inside of
`failIncompleteActionsWithOpTimeout` , I opted to move it into a new method
because `groupAndSendMultiAction` is already quite long and complex and we need
to add more logic to it to handle this bug, I believe its better to do this
timeout handling inside a seperate method that is clearly named with docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
