terrytlu commented on code in PR #6947: URL: https://github.com/apache/hbase/pull/6947#discussion_r2165429416
########## hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestSnapshotRegionSizeCalculator.java: ########## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.snapshot; + +import static org.junit.Assert.assertTrue; + +import java.io.IOException; +import java.util.Map; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.fs.FileSystem; +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.HBaseTestingUtil; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.testclassification.SmallTests; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.hbase.util.CommonFSUtils; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import org.apache.hadoop.hbase.shaded.protobuf.generated.SnapshotProtos; + +@Category(SmallTests.class) +public class TestSnapshotRegionSizeCalculator { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestSnapshotRegionSizeCalculator.class); + + private static final HBaseTestingUtil TEST_UTIL = new HBaseTestingUtil(); + private static FileSystem fs; + private static Path rootDir; + private static Path snapshotDir; + private static SnapshotProtos.SnapshotDescription snapshotDesc; + private static SnapshotManifest manifest; + private static Admin admin; + private static Configuration conf; + + @BeforeClass + public static void setupCluster() throws Exception { + TEST_UTIL.startMiniCluster(3); + conf = TEST_UTIL.getConfiguration(); + fs = TEST_UTIL.getTestFileSystem(); + rootDir = TEST_UTIL.getDataTestDir("TestSnapshotRegionSizeCalculator"); + CommonFSUtils.setRootDir(conf, rootDir); + admin = TEST_UTIL.getAdmin(); + } + + @AfterClass + public static void tearDown() throws Exception { + fs.delete(rootDir, true); + TEST_UTIL.shutdownMiniCluster(); + } + + @Test + public void testCalculateRegionSize() throws IOException { + TableName tableName = TableName.valueOf("test_table"); + String snapshotName = "test_snapshot"; + + // table has no data + TEST_UTIL.createTable(tableName, Bytes.toBytes("info")); + admin = TEST_UTIL.getConnection().getAdmin(); + admin.snapshot(snapshotName, tableName); + Path snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshotName, + TEST_UTIL.getDefaultRootDirPath()); + SnapshotProtos.SnapshotDescription snapshotDesc = + SnapshotDescriptionUtils.readSnapshotInfo(TEST_UTIL.getTestFileSystem(), snapshotDir); + SnapshotManifest manifest = SnapshotManifest.open(TEST_UTIL.getConfiguration(), + TEST_UTIL.getTestFileSystem(), snapshotDir, snapshotDesc); + SnapshotRegionSizeCalculator calculator = + new SnapshotRegionSizeCalculator(TEST_UTIL.getConfiguration(), manifest); + Map<String, Long> regionSizes = calculator.calculateRegionSizes(); + + for (Map.Entry<String, Long> entry : regionSizes.entrySet()) { + assertTrue("Region size should be 0.", entry.getValue() == 0); + } + + admin.deleteSnapshot(snapshotName); + + // table has some data + TEST_UTIL.loadTable(admin.getConnection().getTable(tableName), Bytes.toBytes("info")); + admin.snapshot(snapshotName, tableName); + snapshotDir = SnapshotDescriptionUtils.getCompletedSnapshotDir(snapshotName, + TEST_UTIL.getDefaultRootDirPath()); + snapshotDesc = + SnapshotDescriptionUtils.readSnapshotInfo(TEST_UTIL.getTestFileSystem(), snapshotDir); + manifest = SnapshotManifest.open(TEST_UTIL.getConfiguration(), TEST_UTIL.getTestFileSystem(), + snapshotDir, snapshotDesc); + calculator = new SnapshotRegionSizeCalculator(TEST_UTIL.getConfiguration(), manifest); + regionSizes = calculator.calculateRegionSizes(); + for (Map.Entry<String, Long> entry : regionSizes.entrySet()) { + assertTrue("Region size should be greater than 0.", entry.getValue() > 0); + } + + TEST_UTIL.deleteTable(tableName); + admin.deleteSnapshot(snapshotName); + } +} Review Comment: Hello @guluo2016 , I have seen your comments. I don't know why the test case didn't pass a few days ago, busy resolving it😭... Now it is okay, please review the latest changes, let the test case for two scenarios: 1. table has no data, and region size is 0 2. table has some data, and region size is greater than 0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
