hgromer commented on code in PR #7084:
URL: https://github.com/apache/hbase/pull/7084#discussion_r2167131491
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestSnapshotProcedureRIT.java:
##########
@@ -53,8 +53,7 @@ public void testTableInMergeWhileTakingSnapshot() throws
Exception {
() -> procExec.getProcedure(mergeProcId).getState() ==
ProcedureState.RUNNABLE);
SnapshotProcedure sp = new SnapshotProcedure(procExec.getEnvironment(),
snapshotProto);
long snapshotProcId = procExec.submitProcedure(sp);
- TEST_UTIL.waitFor(2000, 1000, () -> procExec.getProcedure(snapshotProcId)
!= null
Review Comment:
Sure; the SnapshotProcedure will never reach the state where it is running
at the same time that the merge procedures are running because it will now
require an exclusive locks of the table to run. So when we kick off the
SnapshotProcedure, it will sit in the `TableProcedureWaitingQueue` as RUNNABLE
before being scheduled. Therefore,
[this](https://github.com/apache/hbase/blob/f0e0f567c0df5013add6e77c903299a9e9c213f0/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/SnapshotProcedure.java#L241)
code path will never be executed. We can clean this code up too if we'd like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
