[ 
https://issues.apache.org/jira/browse/HBASE-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437873#comment-13437873
 ] 

Jonathan Hsieh commented on HBASE-5714:
---------------------------------------

Jie, looks great and thanks for the testing output.  I have only a one style 
nit i'd like your thoughts on:

Can you make the calls to Runtime.getRuntime().exit(xx) happen in main instead 
of the helper?  If we were to write tests, the exit would make it difficult.


                
> Add write permissions check before any hbck run that modifies hdfs.
> -------------------------------------------------------------------
>
>                 Key: HBASE-5714
>                 URL: https://issues.apache.org/jira/browse/HBASE-5714
>             Project: HBase
>          Issue Type: Sub-task
>          Components: hbck
>    Affects Versions: 0.90.6, 0.92.2, 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>         Attachments: HBASE-5628.patch
>
>
> We encoutered a situation where hbck was run by an under-privileged user that 
> was unable to write/modify/merge regions due to hdfs perms.  Unfortunately, 
> this user was alerted of this  after several minutes of read-only operations. 
>  hbck should fail early by having a write perm check and providing actionable 
> advice to the hbase admin.
> Maybe something like: "Current user yy does not have write perms to <hbase 
> home>. Please run hbck as hdfs user xxx"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to