charlesconnell commented on code in PR #7129:
URL: https://github.com/apache/hbase/pull/7129#discussion_r2175484391
##########
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java:
##########
@@ -724,8 +787,9 @@ private static Pair<SnapshotFileInfo, Long>
getSnapshotFileAndSize(FileSystem fs
* The algorithm used is pretty straightforward; the file list is sorted by
size, and then each
* group fetch the bigger file available, iterating through groups
alternating the direction.
*/
- static List<List<Pair<SnapshotFileInfo, Long>>>
- getBalancedSplits(final List<Pair<SnapshotFileInfo, Long>> files, final
int ngroups) {
+ static List<List<Pair<SnapshotFileInfo, Long>>> getBalancedSplits(
+ final Collection<Pair<SnapshotFileInfo, Long>> unsortedFiles, final int
ngroups) {
Review Comment:
I did this so that a CustomFileGrouper could return a Collection instead of
a List, which I thought was a little nicer API design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
