Copilot commented on code in PR #7126:
URL: https://github.com/apache/hbase/pull/7126#discussion_r2176642646
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/monitor/ExcludeDatanodeManager.java:
##########
@@ -78,7 +79,7 @@ public ExcludeDatanodeManager(Configuration conf) {
public boolean tryAddExcludeDN(DatanodeInfo datanodeInfo, String cause) {
boolean alreadyMarkedSlow = getExcludeDNs().containsKey(datanodeInfo);
if (!alreadyMarkedSlow) {
- excludeDNsCache.put(datanodeInfo, EnvironmentEdgeManager.currentTime());
+ excludeDNsCache.put(datanodeInfo, new Pair(cause,
EnvironmentEdgeManager.currentTime()));
Review Comment:
[nitpick] Consider replacing the generic Pair with a dedicated value type
(e.g., a small class or record) that provides self-documenting field names to
improve long-term code clarity and maintainability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
