[
https://issues.apache.org/jira/browse/HBASE-5251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438096#comment-13438096
]
Jesse Yates commented on HBASE-5251:
------------------------------------
A couple of comments.
bq. + #Formatter is now defined at command group level.
This is extraneous - comments in the Shell.rb or HIRB should make this clear.
Instead, this serves to just reference old code that is no longer present,
making it more confusing than helpful. Something better would be a link to the
method in Shell that takes a formmatter.
bq. AdminFormatter is used for all non row specific operations (command groups)
such as version, status etc.
What does it actually output for these operations?
Otherwise, looks good Sameer.
> Some commands return "0 rows" when > 0 rows were processed successfully
> -----------------------------------------------------------------------
>
> Key: HBASE-5251
> URL: https://issues.apache.org/jira/browse/HBASE-5251
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 0.90.5
> Reporter: David S. Wang
> Assignee: Sameer Vaishampayan
> Priority: Minor
> Labels: noob
> Attachments: patch7.diff, patch8.diff, patch9.diff
>
>
> From the hbase shell, I see this:
> hbase(main):049:0> scan 't1'
> ROW COLUMN+CELL
>
> r1 column=f1:c1, timestamp=1327104295560, value=value
>
> r1 column=f1:c2, timestamp=1327104330625, value=value
>
> 1 row(s) in 0.0300 seconds
> hbase(main):050:0> deleteall 't1', 'r1'
> 0 row(s) in 0.0080 seconds <====== I expected this to read
> "2 row(s)"
> hbase(main):051:0> scan 't1'
> ROW COLUMN+CELL
>
> 0 row(s) in 0.0090 seconds
> I expected the deleteall command to return "1 row(s)" instead of 0, because 1
> row was deleted. Similar behavior for delete and some other commands. Some
> commands such as "put" work fine.
> Looking at the ruby shell code, it seems that formatter.footer() is called
> even for commands that will not actually increment the number of rows
> reported, such as deletes. Perhaps there should be another similar function
> to formatter.footer(), but that will not print out @row_count.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
