Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2217109148
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
I suggest we change the java.min.version to something like
'java.release.version', and set it to 8. And introduce a special property like
'hbase.unsafe.java.version', and set it to 1.8.
So we can use java.version or jdk.version as the name for this property and
set it 17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
