stoty commented on code in PR #7142:
URL: https://github.com/apache/hbase/pull/7142#discussion_r2234911522
##########
hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/tls/TestX509Util.java:
##########
@@ -96,7 +96,16 @@ public void testCreateSSLContextWithClientAuthNONE() throws
Exception {
public void testCreateSSLContextWithoutCustomProtocol() throws Exception {
SslContext sslContext = X509Util.createSslContextForClient(conf);
ByteBufAllocator byteBufAllocatorMock = mock(ByteBufAllocator.class);
- assertArrayEquals(new String[] { X509Util.DEFAULT_PROTOCOL },
+ assertArrayEquals(new String[] { "TLSv1.3", "TLSv1.2" },
Review Comment:
No, these defaults are the same in any current supported JDK branch.
(backported even to JDK8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
