Umeshkumar9414 commented on code in PR #7075:
URL: https://github.com/apache/hbase/pull/7075#discussion_r2238699439
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/AbstractRecoveredEditsOutputSink.java:
##########
@@ -111,6 +128,13 @@ protected Path
closeRecoveredEditsWriterAndFinalizeEdits(RecoveredEditsWriter ed
// TestHLogSplit#testThreading is an example.
Review Comment:
I try to understand the test as how it is creating the fake files that
doesn't exist but I was not able to understand it.
Can we create another issue for this. I will try to understand it and change
the test.
How about adding some testing flag for this ?
While trying to understand this I will try to think of some other way also.
Might be able to mock the rename for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
