[ 
https://issues.apache.org/jira/browse/HBASE-29029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18011808#comment-18011808
 ] 

Vinayak Hegde commented on HBASE-29029:
---------------------------------------

[~dieterdp_ng] Thanks for fixing the issue.

As part of https://issues.apache.org/jira/browse/HBASE-29484, we're updating 
the backup and restore documentation to reflect the latest changes.

Since this Jira also touches the backup and restore components, could you 
please review the changes and check if any updates to the documentation are 
needed? If so, kindly create a sub-task under 
https://issues.apache.org/jira/browse/HBASE-29484 detailing the required 
documentation updates. You’re welcome to assign it to yourself and work on it, 
or we’d be happy to take it up as well.

Thanks!

> Refactor BackupHFileCleaner + fix test
> --------------------------------------
>
>                 Key: HBASE-29029
>                 URL: https://issues.apache.org/jira/browse/HBASE-29029
>             Project: HBase
>          Issue Type: Improvement
>          Components: backup&restore
>    Affects Versions: 2.6.0, 3.0.0, 4.0.0-alpha-1
>            Reporter: Dieter De Paepe
>            Assignee: Dieter De Paepe
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 4.0.0-alpha-1, 2.7.0, 3.0.0-beta-2, 2.6.3
>
>
> The TestBackupHFileCleaner test is broken, as it uses a different API to 
> register bulk loads than the API that is actually used to register bulk loads 
> during backups. The test also incorrectly closes the FS of the 
> HBaseTestingUtil, causing this test to block for about 5 minutes during 
> shutdown.
> Both the test and BackupHFileCleaner itself are overly convoluted and should 
> be cleaned up. This is another intermediate step towards fixing HBASE-28715.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to