Apache9 commented on code in PR #7194:
URL: https://github.com/apache/hbase/pull/7194#discussion_r2264337144
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/SerialReplicationSourceWALReader.java:
##########
@@ -96,6 +96,11 @@ protected void readWALEntries(WALEntryStream entryStream,
WALEntryBatch batch)
break;
}
sleepMultiplier = sleep(sleepMultiplier);
+ // Always make sure to break after handling the exception.
+ // Otherwise we will drop down below into logic to push the entry,
+ // but since we don't know if the entry can be pushed we may push
+ // the entry out of order, breaking serial replication guarantees.
+ break;
Review Comment:
I assume this should be continue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
