DieterDP-ng commented on code in PR #7200: URL: https://github.com/apache/hbase/pull/7200#discussion_r2284967371
########## src/main/asciidoc/_chapters/backup_restore.adoc: ########## @@ -578,32 +578,45 @@ $ hbase backup describe backupId_1467823988425 // hbase backup delete [[br.delete.backup]] -=== Deleting a Backup Image +=== Deleting Backup Images -This command can be used to delete a backup image which is no longer needed. +The `hbase backup delete` command deletes backup images that are no longer needed. Review Comment: Two thing that surprised me when experimenting with backup-restore, and would in my opinion be useful to add, are the following: 1) Deleting a backup will affect all following incremental backups (in the same backup root) up to the next full backup. This might lead to unexpected data loss. An example: assume you do a full backup every 2 weeks, and a daily incremental backup. If you do `hbase backup delete -k 7` and the full backup is older than 7 days, you'll have effectively cleared all incremental backups as well. (The backup will still be listed, but the backup data inside it will be gone.) 2) If the most recent backup is an incremental backup, and you delete it, you should do a full backup next. If you do an incremental backup instead, the backup image may miss data that is present in HBase. (Logged as [HBASE-28084](https://issues.apache.org/jira/browse/HBASE-28084)) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
