Re: [PR] HBASE-29453 : NPE on CacheAwareLoadBalancer.balanceTable [hbase]

[via GitHub]

chandrasekhar-188k commented on PR #7263:
URL: https://github.com/apache/hbase/pull/7263#issuecomment-3247562179

   > In order to reproduce this error and verification, I have to mock 
super.balanceTable() method from CacheAwareLoadBalancer.balanceTable().
   > 
   > For that i've used a workaround by implementing another method called 
callSuperBalanceTable() in CacheAwareLoadBalancer which calls 
super.balanceTable() and mocked callSuperBalanceTable() method in my test.
   > 
   > I am attaching screenshot for more clarification : screenshot of 
CacheAwareLoadBalancer <img alt="image" width="1071" height="706" 
src="https://private-user-images.githubusercontent.com/213584814/484394209-dc89269b-8245-4097-b716-a485a1d9e337.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY4NzAzNjQsIm5iZiI6MTc1Njg3MDA2NCwicGF0aCI6Ii8yMTM1ODQ4MTQvNDg0Mzk0MjA5LWRjODkyNjliLTgyNDUtNDA5Ny1iNzE2LWE0ODVhMWQ5ZTMzNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDkwM1QwMzI3NDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYzNjODE5ZGM5NTM3M2RjMjI1Y2FiNzdlMDUzY2YzZWI1Y2Q4YTFmN2Y4NTIzMGVlNzU0MWJiNzM4Y2JlMzc2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.RmA_3lkKhRaoYOoPNzXc_iZO3jMwVb9LSniF1I2m-44";>
   > 
   > screenshot of unit test <img alt="image" width="1247" height="294" 
src="https://private-user-images.githubusercontent.com/213584814/484395033-a755508d-6090-41b8-a8ed-910b8b295b06.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTY4NzAzNjQsIm5iZiI6MTc1Njg3MDA2NCwicGF0aCI6Ii8yMTM1ODQ4MTQvNDg0Mzk1MDMzLWE3NTU1MDhkLTYwOTAtNDFiOC1hOGVkLTkxMGI4YjI5NWIwNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwOTAzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDkwM1QwMzI3NDRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NTJjOGYxZmFkODg4ODJhNWRjZjlkMmYzNzBmMDRjYzgwOGIyNTNiOWVjZWI2MzQwNWVjZWNlMzE3NTEyMTdlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.zDPe7XjK7W0LLvINTO-EOOwH-ocHbJHsZ6SvyXa1xfc";>
   > 
   > So, this is how i have done verification but i am not so sure if we should 
include this kind of workaround in code. Please let me know if is there any way 
to mock super.balanceTable().
   
   you can refer to the UT in PR: https://github.com/apache/hbase/pull/7266


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org