frostruan commented on PR #5408: URL: https://github.com/apache/hbase/pull/5408#issuecomment-3257904894
> Thanks for reviewing Duo. > > If we want to introduce a general log roll procedure, we should implement it in the hbase-server module. It is not hard. But for log rolling in backup job, there is a little difference. As a sub-step of backup, after completing the log roll, we need to record the highest wal filenum in the backup system table. However hbase-backup is a high-level module built on hbase-server. In theory, hbase-server should not include any backup-related operations, so I am a little confused about how to do log rolling for backup. > > Here are some solutions. First, the backup client could start a general log roll. After the log roll procedure completes, the backup client retrieves the latest WAL filenum from each region server and records it in the backup system table. For the hbase-server module, RSRpcService would need to provide a method for the client to query the latest WAL filenum. > > The second approach is to introduce new procedures in the hbase-backup module, such as BackupLogRollProcedure extends LogRollProcedure and BackupLogRollCallable extends LogRollCallable, and implement backup-related logic in these derived subprocedures. However, we still lack an entry point for submitting such procedures. Should we add a new Backup Service to Backup.proto? Actually I don't like this approach. This implementation is too complicated for the purpose. > > How about I try the first method first? Hi duo , would you mind reviewing the new commit ? @Apache9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
