frostruan commented on code in PR #5408:
URL: https://github.com/apache/hbase/pull/5408#discussion_r2342899143


##########
hbase-protocol-shaded/src/main/protobuf/HBase.proto:
##########
@@ -289,3 +289,7 @@ message RotateFileData {
   required int64 timestamp = 1;
   required bytes data = 2;
 }
+
+message LastHighestWalFilenum {
+  map<string, uint64> file_num = 1;

Review Comment:
   Thanks duo. This is indeed a potential problem. I searched the codebase and 
found that maps are used in other places, such as the headers definition in 
Tracing.proto, the regionCachedInfo definition in ClusterStatus.proto, and many 
data structures in BucketCacheEntry.proto that use maps. Do I need to open 
another issue to change these maps to repeat? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to