Apache9 commented on PR #7313: URL: https://github.com/apache/hbase/pull/7313#issuecomment-3307898395
This class is on a very critital path as lots of performance related code are depended on Unsafe, so for me I do not want to take any risks here... https://github.com/Apache9/hbase/commit/0de962529410bd01528becda429582204cc780ea This is how we can test ByteBufferUtils without unsafe. The change will break TestFromClientSide3WoUnsafe, and TestFromClientSide3WoUnsafe is too complicated, mockStatic can only hack the method on the same thread, so it does not help in TestFromClientSide3WoUnsafe. It is added in HBASE-17872, I prefer we just add a test for MSLab when Unsafe is not available, without using a big tests here, so we can just remove TestFromClientSide3WoUnsafe. WDYT? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
